zend_compile: Bundle function type constants into an zend_function_type enum
#21208
+23
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ype` enum This clarifies the relationship between these constants and improves type safety a little.
iluuu1994
approved these changes
Feb 13, 2026
|
|
||
| #define ZEND_CLASS_CONST_FLAGS(c) Z_CONSTANT_FLAGS((c)->value) | ||
|
|
||
| #if __STDC_VERSION__ >= 202311L |
Member
There was a problem hiding this comment.
I believe this also works for C++11. Not important to me, but maybe other folks.
ndossche
reviewed
Feb 13, 2026
| ZEND_USER_FUNCTION = 2, | ||
| ZEND_EVAL_CODE = 4, | ||
| }; | ||
| typedef enum _zend_function_type zend_function_type; |
Member
There was a problem hiding this comment.
Names starting with underscore are reserved to the implementation .We've previously done effort to get rid of underscores in places and generally don't add new ones.
| }; | ||
| typedef enum _zend_function_type zend_function_type; | ||
| #else | ||
| enum _zend_function_type { |
Member
There was a problem hiding this comment.
A bit unfortunate that this is a duplicated definition. Changing one code smell with another.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This clarifies the relationship between these constants and improves type safety a little.